Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): range selector drag row #1729

Merged
merged 2 commits into from
Apr 13, 2024
Merged

fix(sheet): range selector drag row #1729

merged 2 commits into from
Apr 13, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #xxx, #yyy, #zzzz

@DR-Univer DR-Univer requested a review from wzhudev as a code owner March 28, 2024 15:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 31.61%. Comparing base (893b810) to head (b109fb0).
Report is 54 commits behind head on dev.

Files Patch % Lines
...ets-ui/src/controllers/editor-bridge.controller.ts 0.00% 3 Missing ⚠️
...ui/src/controllers/doc-editor-bridge.controller.ts 0.00% 2 Missing ⚠️
...ets/src/commands/commands/utils/selection-utils.ts 0.00% 2 Missing ⚠️
...ts-ui/src/controllers/shortcuts/editor.shortcut.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1729      +/-   ##
==========================================
- Coverage   31.78%   31.61%   -0.17%     
==========================================
  Files        1041     1044       +3     
  Lines       57853    57889      +36     
  Branches    12165    12172       +7     
==========================================
- Hits        18387    18301      -86     
- Misses      39466    39588     +122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Mar 29, 2024
@DR-Univer DR-Univer added qa:untested This PR is ready to be tested and removed qa:rejected labels Apr 1, 2024
@zhaolixin7
Copy link

@DR-Univer 无效选区仍可以应用
image

@univer-bot
Copy link

univer-bot bot commented Apr 7, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@DR-Univer Invalid selections can still be applied
image

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 7, 2024
@DR-Univer
Copy link
Collaborator Author

@Gggpound 这个也得你在外部判断了

@univer-bot
Copy link

univer-bot bot commented Apr 9, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Gggpound This also needs to be judged externally.

@DR-Univer DR-Univer merged commit 530a852 into dev Apr 13, 2024
7 of 8 checks passed
@DR-Univer DR-Univer deleted the fix-range-selector-drag-row branch April 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev Awaiting requested review from wzhudev wzhudev is a code owner

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Assignees
No one assigned
Labels
qa:rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DR-Univer @zhaolixin7